fix: ISR support for adapter-vercel#9063
Merged
Rich-Harris merged 9 commits intomasterfrom Feb 17, 2023
Merged
Conversation
dummdidumm
reviewed
Feb 16, 2023
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
In line 223 (previously 215) there's a special handling for the common case of a single group. I think the if-condition needs to be adjusted here to also check that there's no ISR config. Because if the functions isn't set there, ISR will not picked up (functions is just empty). This could happen if you set IRS at the adapter level.
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
dummdidumm
reviewed
Feb 17, 2023
packages/adapter-vercel/index.js
Outdated
| if (name) { | ||
| static_config.routes.push({ src, dest: `/${name}` }); | ||
| functions.delete(pattern); | ||
| const isr = isr_config.get(route); |
Member
There was a problem hiding this comment.
If you don't have any route config, we'll never get into here because functions is empty (because of line 216)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shipped incremental static regeneration on Vercel last week, but it was broken. Turns out there were a few extra hoops to jump through.
Brief explanation of the changes:
group, so that if you invalidate/fooyou simultaneously invalidate/foo/__data.json— this is assigned automatically__pathnamequery parameter.req.urlis reconstructed byadapter-vercelbefore the request is handed off to SvelteKit/fooor/foo/__data.jsonis being requested, while still allowing/fooand/foo/__data.jsonto be invalidate simultaneously, we need to create two Vercel routes for each SvelteKit route withisr. To save space, these are symlinks rather than duplicatesPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.